chrome/browser/extensions/test_extension_prefs.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/test_extension_prefs.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/test_extension_prefs.cc

diff --git a/chrome/browser/extensions/test_extension_prefs.cc b/chrome/browser/extensions/test_extension_prefs.cc

index 1810418fd3458164c8ba8bb8036057b5fca4b738..4c420cca521a68bf2157efc9c0c1d126186544ed 100644

--- a/chrome/browser/extensions/test_extension_prefs.cc

+++ b/chrome/browser/extensions/test_extension_prefs.cc

@@ -19,6 +19,7 @@

#include "chrome/browser/prefs/pref_service_mock_factory.h"

#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/common/chrome_constants.h"

+#include "components/crx_file/id_util.h"

#include "components/pref_registry/pref_registry_syncable.h"

#include "content/public/browser/browser_thread.h"

#include "extensions/browser/extension_pref_store.h"

@@ -161,7 +162,7 @@ scoped_refptr<Extension> TestExtensionPrefs::AddExtensionWithManifestAndFlags(

if (!extension.get())

return NULL;

- EXPECT_TRUE(Extension::IdIsValid(extension->id()));

+ EXPECT_TRUE(crx_file::id_util::IdIsValid(extension->id()));

prefs_->OnExtensionInstalled(extension.get(),

Extension::ENABLED,

syncer::StringOrdinal::CreateInitialOrdinal(),