chrome/browser/extensions/external_provider_impl.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_provider_impl.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_provider_impl.cc

diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc

index 13914f4d4685df354bf922a38a28533130af61a8..d4ab6c9b1398466f323c12e4111e35c3040ec651 100644

--- a/chrome/browser/extensions/external_provider_impl.cc

+++ b/chrome/browser/extensions/external_provider_impl.cc

@@ -26,6 +26,7 @@

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

+#include "components/crx_file/id_util.h"

#include "content/public/browser/browser_thread.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/external_provider_interface.h"

@@ -114,7 +115,7 @@ void ExternalProviderImpl::SetPrefs(base::DictionaryValue* prefs) {

const std::string& extension_id = i.key();

const base::DictionaryValue* extension = NULL;

- if (!Extension::IdIsValid(extension_id)) {

+ if (!crx_file::id_util::IdIsValid(extension_id)) {

LOG(WARNING) << "Malformed extension dictionary: key "

<< extension_id.c_str() << " is not a valid id.";

continue;