chrome/browser/extensions/webstore_standalone_installer.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_standalone_installer.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_standalone_installer.cc

diff --git a/chrome/browser/extensions/webstore_standalone_installer.cc b/chrome/browser/extensions/webstore_standalone_installer.cc

index 859cf48067c0ff3161a98ef25739f088b57bd2b3..dc9ea0efdf251a5aa54c0c03d6b66805291d7973 100644

--- a/chrome/browser/extensions/webstore_standalone_installer.cc

+++ b/chrome/browser/extensions/webstore_standalone_installer.cc

@@ -14,6 +14,7 @@

#include "chrome/browser/extensions/install_tracker.h"

#include "chrome/browser/extensions/webstore_data_fetcher.h"

#include "chrome/browser/profiles/profile.h"

+#include "components/crx_file/id_util.h"

#include "content/public/browser/web_contents.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

@@ -55,7 +56,7 @@ void WebstoreStandaloneInstaller::BeginInstall() {

// AbortInstall, which both release this ref.

AddRef();

- if (!Extension::IdIsValid(id_)) {

+ if (!crx_file::id_util::IdIsValid(id_)) {

CompleteInstall(webstore_install::INVALID_ID, kInvalidWebstoreItemId);

return;

}