Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: extensions/common/BUILD.gn

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | extensions/common/extension.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 6
7 # GYP version: extensions/extensions.gyp:extensions_common 7 # GYP version: extensions/extensions.gyp:extensions_common
8 source_set("common") { 8 source_set("common") {
9 sources = [ 9 sources = [
10 "api/messaging/message.h", 10 "api/messaging/message.h",
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 "features/manifest_feature.cc", 71 "features/manifest_feature.cc",
72 "features/manifest_feature.h", 72 "features/manifest_feature.h",
73 "features/permission_feature.cc", 73 "features/permission_feature.cc",
74 "features/permission_feature.h", 74 "features/permission_feature.h",
75 "features/simple_feature.cc", 75 "features/simple_feature.cc",
76 "features/simple_feature.h", 76 "features/simple_feature.h",
77 "features/simple_feature_filter.cc", 77 "features/simple_feature_filter.cc",
78 "features/simple_feature_filter.h", 78 "features/simple_feature_filter.h",
79 "file_util.cc", 79 "file_util.cc",
80 "file_util.h", 80 "file_util.h",
81 "id_util.cc",
82 "id_util.h",
83 "install_warning.cc", 81 "install_warning.cc",
84 "install_warning.h", 82 "install_warning.h",
85 "manifest.cc", 83 "manifest.cc",
86 "manifest.h", 84 "manifest.h",
87 "manifest_constants.cc", 85 "manifest_constants.cc",
88 "manifest_constants.h", 86 "manifest_constants.h",
89 "manifest_handler.cc", 87 "manifest_handler.cc",
90 "manifest_handler.h", 88 "manifest_handler.h",
91 "manifest_handler_helpers.cc", 89 "manifest_handler_helpers.cc",
92 "manifest_handler_helpers.h", 90 "manifest_handler_helpers.h",
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 "value_counter.h", 175 "value_counter.h",
178 "view_type.cc", 176 "view_type.cc",
179 "view_type.h", 177 "view_type.h",
180 ] 178 ]
181 179
182 deps = [ 180 deps = [
183 # TODO(benwells): figure out what to do with the api target and 181 # TODO(benwells): figure out what to do with the api target and
184 # api resources compiled into the chrome resource bundle. 182 # api resources compiled into the chrome resource bundle.
185 # http://crbug.com/162530 183 # http://crbug.com/162530
186 "//chrome:resources", 184 "//chrome:resources",
185 "//components/crx_file",
187 "//components/url_matcher", 186 "//components/url_matcher",
188 "//content/public/common", 187 "//content/public/common",
189 "//crypto", 188 "//crypto",
190 "//extensions/common/api", 189 "//extensions/common/api",
191 "//extensions/strings", 190 "//extensions/strings",
192 "//ipc", 191 "//ipc",
193 "//net", 192 "//net",
194 "//third_party/icu", 193 "//third_party/icu",
195 "//third_party/re2", 194 "//third_party/re2",
196 "//ui/base", 195 "//ui/base",
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 "manifest_handlers/nacl_modules_handler.h", 227 "manifest_handlers/nacl_modules_handler.h",
229 ] 228 ]
230 } 229 }
231 230
232 if (is_win) { 231 if (is_win) {
233 cflags = [ 232 cflags = [
234 "/wd4267", # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 233 "/wd4267", # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
235 ] 234 ]
236 } 235 }
237 } 236 }
OLDNEW
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | extensions/common/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698