extensions/browser/verified_contents.cc - Issue 481433005: Extensions: Move id_util functions to crx_file component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/verified_contents.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert last patchset. function returns Extension* and can't use an assert. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/verified_contents.cc

diff --git a/extensions/browser/verified_contents.cc b/extensions/browser/verified_contents.cc

index f4272b7ceeb7d6701e7ed98ffc8acac051f3a20e..b92e72d3210a106eaedac12761ebd359a8345f35 100644

--- a/extensions/browser/verified_contents.cc

+++ b/extensions/browser/verified_contents.cc

@@ -9,6 +9,7 @@

#include "base/json/json_reader.h"

#include "base/strings/string_util.h"

#include "base/values.h"

+#include "components/crx_file/id_util.h"

#include "crypto/signature_verifier.h"

#include "extensions/common/extension.h"

@@ -131,7 +132,7 @@ bool VerifiedContents::InitFrom(const base::FilePath& path,

std::string item_id;

if (!dictionary->GetString(kItemIdKey, &item_id) ||

- !Extension::IdIsValid(item_id))

+ !crx_file::id_util::IdIsValid(item_id))

return false;

extension_id_ = item_id;

« no previous file with comments | « extensions/browser/file_reader_unittest.cc ('k') | extensions/common/BUILD.gn » ('j') | no next file with comments »