Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix dart2js warnings and add test to ensure it stays clean. Filed https://github.com/dart-lang/sdk/issues/29224 to track all the problems that require ignore. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/5bdc1199caab3682820da6153f8a9f068f2a6de7

Patch Set 1 #

Patch Set 2 : Fix merge problems. #

Patch Set 3 : Remove unused method. #

Total comments: 16

Patch Set 4 : Address comments and fix duplicated library names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -77 lines) Patch
A pkg/compiler/analysis_options.yaml View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/builder_kernel.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/io/line_column_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/operators.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/type_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 3 4 chunks +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/variable_allocator.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A pkg/compiler/testing.json View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/front_end/analysis_options.yaml View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/analyze_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/testing/lib/src/test_dart/path.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/lib/src/test_dart/status_expression.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/lib/src/test_dart/status_file_parser.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A tests/compiler/dart2js/analyze_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ahe
3 years, 8 months ago (2017-04-03 11:34:15 UTC) #6
Johnni Winther
lgtm https://codereview.chromium.org/2791993002/diff/100001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2791993002/diff/100001/pkg/compiler/lib/src/js_backend/backend.dart#newcode987 pkg/compiler/lib/src/js_backend/backend.dart:987: VariableElement variableElement = element as VariableElement; Why is ...
3 years, 8 months ago (2017-04-03 12:07:33 UTC) #7
ahe
Thank you, Johnni! https://codereview.chromium.org/2791993002/diff/100001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2791993002/diff/100001/pkg/compiler/lib/src/js_backend/backend.dart#newcode987 pkg/compiler/lib/src/js_backend/backend.dart:987: VariableElement variableElement = element as VariableElement; ...
3 years, 8 months ago (2017-04-03 12:25:07 UTC) #8
ahe
3 years, 8 months ago (2017-04-03 13:08:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:120001) manually as
5bdc1199caab3682820da6153f8a9f068f2a6de7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698