Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Side by Side Diff: pkg/compiler/lib/src/common_elements.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/compiler.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // TODO(sigmund): rename and move to common/elements.dart 5 // TODO(sigmund): rename and move to common/elements.dart
6 library dart2js.type_system; 6 library dart2js.type_system;
7 7
8 import 'common.dart';
9 import 'common/names.dart' show Uris; 8 import 'common/names.dart' show Uris;
10 import 'elements/types.dart'; 9 import 'elements/types.dart';
11 import 'elements/entities.dart'; 10 import 'elements/entities.dart';
12 11
13 /// The common elements and types in Dart. 12 /// The common elements and types in Dart.
14 abstract class CommonElements { 13 abstract class CommonElements {
15 /// The `Object` class defined in 'dart:core'. 14 /// The `Object` class defined in 'dart:core'.
16 ClassEntity get objectClass; 15 ClassEntity get objectClass;
17 16
18 /// The `bool` class defined in 'dart:core'. 17 /// The `bool` class defined in 'dart:core'.
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
555 } 554 }
556 555
557 @override 556 @override
558 InterfaceType streamType([DartType elementType]) { 557 InterfaceType streamType([DartType elementType]) {
559 if (elementType == null) { 558 if (elementType == null) {
560 return getRawType(streamClass); 559 return getRawType(streamClass);
561 } 560 }
562 return createInterfaceType(streamClass, [elementType]); 561 return createInterfaceType(streamClass, [elementType]);
563 } 562 }
564 } 563 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698