pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

index 07b665a5e0ec689e385900c15f513cdacd797a0b..0cb1a0697806269f3561d67f01180c982af746ea 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

@@ -33,8 +33,7 @@ import '../../elements/elements.dart'

import '../../elements/entities.dart';

import '../../hash/sha1.dart' show Hasher;

import '../../io/code_output.dart';

-import '../../io/line_column_provider.dart'

- show LineColumnCollector, LineColumnProvider;

+import '../../io/line_column_provider.dart' show LineColumnCollector;

import '../../io/source_map_builder.dart' show SourceMapBuilder;

import '../../js/js.dart' as jsAst;

import '../../js/js.dart' show js;