Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: pkg/compiler/lib/src/library_loader.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.library_loader; 5 library dart2js.library_loader;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'common/names.dart' show Uris; 9 import 'common/names.dart' show Uris;
10 import 'common/tasks.dart' show CompilerTask, Measurer; 10 import 'common/tasks.dart' show CompilerTask, Measurer;
(...skipping 18 matching lines...) Expand all
29 SyntheticImportElement; 29 SyntheticImportElement;
30 import 'enqueue.dart' show DeferredAction; 30 import 'enqueue.dart' show DeferredAction;
31 import 'environment.dart'; 31 import 'environment.dart';
32 import 'patch_parser.dart' show PatchParserTask; 32 import 'patch_parser.dart' show PatchParserTask;
33 import 'resolved_uri_translator.dart'; 33 import 'resolved_uri_translator.dart';
34 import 'script.dart'; 34 import 'script.dart';
35 import 'serialization/serialization.dart' show LibraryDeserializer; 35 import 'serialization/serialization.dart' show LibraryDeserializer;
36 import 'tree/tree.dart'; 36 import 'tree/tree.dart';
37 import 'util/util.dart' show Link, LinkBuilder; 37 import 'util/util.dart' show Link, LinkBuilder;
38 38
39 import 'package:front_end/src/fasta/scanner.dart' show Token;
40
41 typedef Future<Iterable<LibraryElement>> ReuseLibrariesFunction( 39 typedef Future<Iterable<LibraryElement>> ReuseLibrariesFunction(
42 Iterable<LibraryElement> libraries); 40 Iterable<LibraryElement> libraries);
43 41
44 typedef Uri PatchResolverFunction(String dartLibraryPath); 42 typedef Uri PatchResolverFunction(String dartLibraryPath);
45 43
46 /** 44 /**
47 * [CompilerTask] for loading libraries and setting up the import/export scopes. 45 * [CompilerTask] for loading libraries and setting up the import/export scopes.
48 * 46 *
49 * The library loader uses four different kinds of URIs in different parts of 47 * The library loader uses four different kinds of URIs in different parts of
50 * the loading process. 48 * the loading process.
(...skipping 1501 matching lines...) Expand 10 before | Expand all | Expand 10 after
1552 } 1550 }
1553 1551
1554 /// API used by the library loader to synchronously scan a library or 1552 /// API used by the library loader to synchronously scan a library or
1555 /// compilation unit and ensure that their library tags are computed. 1553 /// compilation unit and ensure that their library tags are computed.
1556 abstract class ElementScanner { 1554 abstract class ElementScanner {
1557 void scanLibrary(LibraryElement library); 1555 void scanLibrary(LibraryElement library);
1558 void scanUnit(CompilationUnitElement unit); 1556 void scanUnit(CompilationUnitElement unit);
1559 } 1557 }
1560 1558
1561 const _reuseLibrarySubtaskName = "Reuse library"; 1559 const _reuseLibrarySubtaskName = "Reuse library";
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_visitor.dart ('k') | pkg/compiler/lib/src/native/enqueue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698