Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: pkg/compiler/lib/src/tree/nodes.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/variable_allocator.dart ('k') | pkg/compiler/testing.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree/nodes.dart
diff --git a/pkg/compiler/lib/src/tree/nodes.dart b/pkg/compiler/lib/src/tree/nodes.dart
index 934d45a1dcae9e15340305feff91221a35f67f76..39280dc0b99a72fded529972027c2c84e8405cb0 100644
--- a/pkg/compiler/lib/src/tree/nodes.dart
+++ b/pkg/compiler/lib/src/tree/nodes.dart
@@ -239,7 +239,7 @@ abstract class Visitor1<R, A> {
R visitNewExpression(NewExpression node, A arg) => visitExpression(node, arg);
R visitNodeList(NodeList node, A arg) => visitNode(node, arg);
R visitNominalTypeAnnotation(NominalTypeAnnotation node, A arg) {
- visitTypeAnnotation(node, arg);
+ return visitTypeAnnotation(node, arg);
}
R visitOperator(Operator node, A arg) => visitIdentifier(node, arg);
@@ -1218,7 +1218,7 @@ class LiteralInt extends Literal<int> {
}
return int.parse(valueToken.lexeme);
} on FormatException catch (ex) {
- (this.handler)(token, ex);
+ throw handler(token, ex);
}
}
@@ -1241,7 +1241,7 @@ class LiteralDouble extends Literal<double> {
}
return double.parse(valueToken.lexeme);
} on FormatException catch (ex) {
- (this.handler)(token, ex);
+ throw handler(token, ex);
}
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/variable_allocator.dart ('k') | pkg/compiler/testing.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698