Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: pkg/compiler/lib/src/dart2js.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.cmdline; 5 library dart2js.cmdline;
6 6
7 import 'dart:async' show EventSink, Future; 7 import 'dart:async' show Future;
8 import 'dart:convert' show UTF8, LineSplitter; 8 import 'dart:convert' show UTF8, LineSplitter;
9 import 'dart:io' show exit, File, FileMode, Platform, stdin, stderr; 9 import 'dart:io' show exit, File, FileMode, Platform, stdin, stderr;
10 10
11 import 'package:package_config/discovery.dart' show findPackages; 11 import 'package:package_config/discovery.dart' show findPackages;
12 12
13 import '../compiler_new.dart' as api; 13 import '../compiler_new.dart' as api;
14 import 'commandline_options.dart'; 14 import 'commandline_options.dart';
15 import 'common/names.dart' show Uris; 15 import 'common/names.dart' show Uris;
16 import 'filenames.dart'; 16 import 'filenames.dart';
17 import 'io/source_file.dart'; 17 import 'io/source_file.dart';
(...skipping 1019 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 @override 1037 @override
1038 void add(String event) { 1038 void add(String event) {
1039 sb.write(event); 1039 sb.write(event);
1040 } 1040 }
1041 1041
1042 @override 1042 @override
1043 void close() { 1043 void close() {
1044 // Do nothing. 1044 // Do nothing.
1045 } 1045 }
1046 } 1046 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/constants/expressions.dart ('k') | pkg/compiler/lib/src/elements/elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698