pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

index 799e28897030a6c383d13acb4bc44a447687a297..91a189bb6691dc31f9bb415ca494d625c1fa49e7 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

@@ -132,8 +132,9 @@ jsAst.Statement buildSetupProgram(Program program, Compiler compiler,

'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),

'hasRetainedMetadata': backend.mirrorsData.hasRetainedMetadata,

'types': typesAccess,

- 'objectClassName': js.quoteName(

- namer.runtimeTypeName(compiler.commonElements.objectClass as Entity)),

+ 'objectClassName': js.quoteName(namer.runtimeTypeName(

+ // ignore: UNNECESSARY_CAST

+ compiler.commonElements.objectClass as Entity)),

'needsStructuredMemberInfo': emitter.needsStructuredMemberInfo,

'usesMangledNames': compiler.commonElements.mirrorsLibrary != null ||

backend.backendUsage.isFunctionApplyUsed,