Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: pkg/compiler/lib/src/inferrer/inferrer_engine.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/inferrer/inferrer_engine.dart
diff --git a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
index e91a884b004a2f3b14c173578f1e5ccac30bca8e..3296ff1481fcc9c3e716ea3934accb2ce40cb797 100644
--- a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
+++ b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
@@ -474,11 +474,12 @@ class InferrerEngine {
if (analyzedElements.contains(element)) return;
analyzedElements.add(element);
- var visitor = compiler.options.kernelGlobalInference
+ dynamic visitor = compiler.options.kernelGlobalInference
? new KernelTypeGraphBuilder(element, resolvedAst, compiler, this)
: new ElementGraphBuilder(element, resolvedAst, compiler, this);
TypeInformation type;
reporter.withCurrentElement(element, () {
+ // ignore: UNDEFINED_METHOD
type = visitor.run();
});
addedInGraph++;
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder_kernel.dart ('k') | pkg/compiler/lib/src/io/line_column_provider.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698