pkg/compiler/lib/src/serialization/serialization.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/serialization/serialization.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/serialization/serialization.dart

diff --git a/pkg/compiler/lib/src/serialization/serialization.dart b/pkg/compiler/lib/src/serialization/serialization.dart

index aee1504491a5d6550023deb624fabdbe5efad7cb..e127bbce2a878e5010d90c07b306e8c04e31f395 100644

--- a/pkg/compiler/lib/src/serialization/serialization.dart

+++ b/pkg/compiler/lib/src/serialization/serialization.dart

@@ -939,7 +939,7 @@ class DeserializerPlugin {

void onElement(Element element, ObjectDecoder getDecoder(String tag)) {}

/// Called to deserialize custom data from [decoder].

- dynamic onData(ObjectDecoder decoder) {}

+ dynamic onData(ObjectDecoder decoder) => null;

}

/// Context for parallel deserialization.