Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_visitor.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | pkg/compiler/lib/src/library_loader.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/kernel_visitor.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_visitor.dart b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
index a6527127585450b157f93c07ab48f721fe2ae4e9..c5841c61d47d6207be5c6da968ab0e8ad5402960 100644
--- a/pkg/compiler/lib/src/kernel/kernel_visitor.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
@@ -353,6 +353,7 @@ class KernelVisitor extends Object
}
@override
+ // ignore: INVALID_METHOD_OVERRIDE_RETURN_TYPE
ir.Expression visitIdentifier(Identifier node) {
// TODO(ahe): Shouldn't have to override this method, but
// [SemanticSendResolvedMixin.visitIdentifier] may return `null` on errors.
@@ -1806,6 +1807,7 @@ class KernelVisitor extends Object
return buildLocalGet(element);
}
+ // ignore: MISSING_RETURN
ir.Expression buildCompound(
Accessor accessor, CompoundRhs rhs, SendSet node) {
ir.Name name = kernel.irName(rhs.operator.selectorName, currentElement);
@@ -2875,6 +2877,7 @@ class KernelVisitor extends Object
}
@override
+ // ignore: INVALID_METHOD_OVERRIDE_RETURN_TYPE
ir.Node visitVariableDefinitions(VariableDefinitions definitions) {
// TODO(ahe): This method is copied from [SemanticDeclarationResolvedMixin]
// and modified. Perhaps we can find a way to avoid code duplication.
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | pkg/compiler/lib/src/library_loader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698