Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen_listener.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library js_backend.backend.codegen_listener; 5 library js_backend.backend.codegen_listener;
6 6
7 import '../common.dart';
8 import '../common/backend_api.dart'; 7 import '../common/backend_api.dart';
9 import '../common/names.dart' show Identifiers; 8 import '../common/names.dart' show Identifiers;
10 import '../common_elements.dart' show CommonElements, ElementEnvironment; 9 import '../common_elements.dart' show CommonElements, ElementEnvironment;
11 import '../constants/values.dart'; 10 import '../constants/values.dart';
12 import '../dump_info.dart' show DumpInfoTask;
13 import '../elements/elements.dart'; 11 import '../elements/elements.dart';
14 import '../elements/entities.dart'; 12 import '../elements/entities.dart';
15 import '../elements/resolution_types.dart'; 13 import '../elements/resolution_types.dart';
16 import '../enqueue.dart' show Enqueuer, EnqueuerListener; 14 import '../enqueue.dart' show Enqueuer, EnqueuerListener;
17 import '../native/enqueue.dart'; 15 import '../native/enqueue.dart';
18 import '../universe/call_structure.dart' show CallStructure; 16 import '../universe/call_structure.dart' show CallStructure;
19 import '../universe/use.dart' show StaticUse, TypeUse; 17 import '../universe/use.dart' show StaticUse, TypeUse;
20 import '../universe/world_impact.dart' 18 import '../universe/world_impact.dart'
21 show WorldImpact, WorldImpactBuilder, WorldImpactBuilderImpl; 19 show WorldImpact, WorldImpactBuilder, WorldImpactBuilderImpl;
22 import 'backend.dart'; 20 import 'backend.dart';
23 import 'backend_helpers.dart'; 21 import 'backend_helpers.dart';
24 import 'backend_impact.dart'; 22 import 'backend_impact.dart';
25 import 'backend_usage.dart'; 23 import 'backend_usage.dart';
26 import 'constant_handler_javascript.dart';
27 import 'custom_elements_analysis.dart'; 24 import 'custom_elements_analysis.dart';
28 import 'lookup_map_analysis.dart' show LookupMapAnalysis; 25 import 'lookup_map_analysis.dart' show LookupMapAnalysis;
29 import 'mirrors_analysis.dart'; 26 import 'mirrors_analysis.dart';
30 import 'mirrors_data.dart';
31 import 'type_variable_handler.dart'; 27 import 'type_variable_handler.dart';
32 28
33 class CodegenEnqueuerListener extends EnqueuerListener { 29 class CodegenEnqueuerListener extends EnqueuerListener {
34 final ElementEnvironment _elementEnvironment; 30 final ElementEnvironment _elementEnvironment;
35 final CommonElements _commonElements; 31 final CommonElements _commonElements;
36 final BackendHelpers _helpers; 32 final BackendHelpers _helpers;
37 final BackendImpacts _impacts; 33 final BackendImpacts _impacts;
38 final BackendClasses _backendClasses; 34 final BackendClasses _backendClasses;
39 35
40 final BackendUsage _backendUsage; 36 final BackendUsage _backendUsage;
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 WorldImpact registerInstantiatedClass(ClassEntity cls) { 337 WorldImpact registerInstantiatedClass(ClassEntity cls) {
342 return _processClass(cls); 338 return _processClass(cls);
343 } 339 }
344 340
345 @override 341 @override
346 void logSummary(void log(String message)) { 342 void logSummary(void log(String message)) {
347 _lookupMapAnalysis.logSummary(log); 343 _lookupMapAnalysis.logSummary(log);
348 _nativeEnqueuer.logSummary(log); 344 _nativeEnqueuer.logSummary(log);
349 } 345 }
350 } 346 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend_helpers.dart ('k') | pkg/compiler/lib/src/js_backend/interceptor_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698