Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: pkg/compiler/lib/src/io/position_information.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/io/line_column_provider.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/io/position_information.dart
diff --git a/pkg/compiler/lib/src/io/position_information.dart b/pkg/compiler/lib/src/io/position_information.dart
index 35605748134be06cc0aba0d8078a4cb3de855f4e..0400e61535cb427281ccdc37dd81b9043bc5d15f 100644
--- a/pkg/compiler/lib/src/io/position_information.dart
+++ b/pkg/compiler/lib/src/io/position_information.dart
@@ -305,6 +305,7 @@ class CodePosition {
CodePosition(this.startPosition, this.endPosition, this.closingPosition);
+ // ignore: MISSING_RETURN
int getPosition(CodePositionKind kind) {
switch (kind) {
case CodePositionKind.START:
@@ -379,6 +380,7 @@ enum SourcePositionKind {
INNER,
}
+// ignore: MISSING_RETURN
SourceLocation getSourceLocation(SourceInformation sourceInformation,
[SourcePositionKind sourcePositionKind = SourcePositionKind.START]) {
if (sourceInformation == null) return null;
« no previous file with comments | « pkg/compiler/lib/src/io/line_column_provider.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698