Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/compiler/lib/src/serialization/serialization_util.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/serialization/serialization_util.dart
diff --git a/pkg/compiler/lib/src/serialization/serialization_util.dart b/pkg/compiler/lib/src/serialization/serialization_util.dart
index 8816cbdd5e24167abdefb4592ee6af193d56fca3..b58d339fbe4154f259f078cf9dcd1e41f217fa81 100644
--- a/pkg/compiler/lib/src/serialization/serialization_util.dart
+++ b/pkg/compiler/lib/src/serialization/serialization_util.dart
@@ -191,6 +191,7 @@ void serializeSendStructure(
}
/// Deserialize a [SendStructure] from [decoder].
+// ignore: MISSING_RETURN
SendStructure deserializeSendStructure(ObjectDecoder decoder) {
SendStructureKind kind = decoder.getEnum(Key.KIND, SendStructureKind.values);
switch (kind) {
@@ -341,6 +342,7 @@ void serializeNewStructure(NewStructure newStructure, ObjectEncoder encoder) {
}
/// Deserialize a [NewStructure] from [decoder].
+// ignore: MISSING_RETURN
NewStructure deserializeNewStructure(ObjectDecoder decoder) {
NewStructureKind kind = decoder.getEnum(Key.KIND, NewStructureKind.values);
switch (kind) {
@@ -421,6 +423,7 @@ void serializeAccessSemantics(
}
/// Deserialize a [AccessSemantics] from [decoder].
+// ignore: MISSING_RETURN
AccessSemantics deserializeAccessSemantics(ObjectDecoder decoder) {
AccessKind kind = decoder.getEnum(Key.KIND, AccessKind.values);
switch (kind) {
« no previous file with comments | « pkg/compiler/lib/src/serialization/serialization.dart ('k') | pkg/compiler/lib/src/serialization/type_serialization.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698