Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import '../compiler.dart' show Compiler;
6 import '../constants/constant_system.dart'; 5 import '../constants/constant_system.dart';
7 import '../constants/values.dart'; 6 import '../constants/values.dart';
8 import '../elements/elements.dart' show Name; 7 import '../elements/elements.dart' show Name;
9 import '../elements/entities.dart'; 8 import '../elements/entities.dart';
10 import '../js_backend/js_backend.dart';
11 import '../js_backend/backend_helpers.dart'; 9 import '../js_backend/backend_helpers.dart';
12 import '../options.dart'; 10 import '../options.dart';
13 import '../types/types.dart'; 11 import '../types/types.dart';
14 import '../universe/call_structure.dart'; 12 import '../universe/call_structure.dart';
15 import '../universe/selector.dart'; 13 import '../universe/selector.dart';
16 import '../world.dart' show ClosedWorld; 14 import '../world.dart' show ClosedWorld;
17 import 'nodes.dart'; 15 import 'nodes.dart';
18 import 'types.dart'; 16 import 'types.dart';
19 17
20 /** 18 /**
(...skipping 1113 matching lines...) Expand 10 before | Expand all | Expand 10 after
1134 ClosedWorld closedWorld) { 1132 ClosedWorld closedWorld) {
1135 HInstruction receiver = instruction.getDartReceiver(closedWorld); 1133 HInstruction receiver = instruction.getDartReceiver(closedWorld);
1136 if (receiver.isNumberOrNull(closedWorld)) { 1134 if (receiver.isNumberOrNull(closedWorld)) {
1137 // Even if there is no builtin equivalent instruction, we know the 1135 // Even if there is no builtin equivalent instruction, we know the
1138 // instruction does not have any side effect, and that it can be GVN'ed. 1136 // instruction does not have any side effect, and that it can be GVN'ed.
1139 clearAllSideEffects(instruction); 1137 clearAllSideEffects(instruction);
1140 } 1138 }
1141 return null; 1139 return null;
1142 } 1140 }
1143 } 1141 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/ssa/graph_builder.dart ('k') | pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698