Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: pkg/compiler/lib/src/ssa/optimize.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/nodes.dart ('k') | pkg/compiler/lib/src/ssa/variable_allocator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/optimize.dart
diff --git a/pkg/compiler/lib/src/ssa/optimize.dart b/pkg/compiler/lib/src/ssa/optimize.dart
index b85a680e99da97fb49b8d6449f4954b0fe22d643..ffae6e77f5eb1fa79d4e2523f269e020fe0d561a 100644
--- a/pkg/compiler/lib/src/ssa/optimize.dart
+++ b/pkg/compiler/lib/src/ssa/optimize.dart
@@ -518,7 +518,9 @@ class SsaInstructionSimplifier extends HBaseVisitor
!node.isCallOnInterceptor(_closedWorld)) {
HInstruction receiver = node.getDartReceiver(_closedWorld);
TypeMask type = TypeMaskFactory.inferredTypeForMember(
- field as Entity, _globalInferenceResults);
+ // ignore: UNNECESSARY_CAST
+ field as Entity,
+ _globalInferenceResults);
HInstruction load = new HFieldGet(field, receiver, type);
node.block.addBefore(node, load);
Selector callSelector = new Selector.callClosureFrom(node.selector);
@@ -995,7 +997,9 @@ class SsaInstructionSimplifier extends HBaseVisitor
_nativeData.getNativeFieldLoadBehavior(field), _closedWorld);
} else {
type = TypeMaskFactory.inferredTypeForMember(
- field as Entity, _globalInferenceResults);
+ // ignore: UNNECESSARY_CAST
+ field as Entity,
+ _globalInferenceResults);
}
return new HFieldGet(field, receiver, type, isAssignable: isAssignable);
@@ -2379,7 +2383,9 @@ class SsaLoadElimination extends HBaseVisitor implements OptimizationPhase {
int argumentIndex = 0;
compiler.codegenWorldBuilder.forEachInstanceField(instruction.element,
(_, FieldEntity member) {
- if (compiler.elementHasCompileTimeError(member as Entity)) return;
+ if (compiler.elementHasCompileTimeError(
+ // ignore: UNNECESSARY_CAST
+ member as Entity)) return;
memorySet.registerFieldValue(
member, instruction, instruction.inputs[argumentIndex++]);
});
« no previous file with comments | « pkg/compiler/lib/src/ssa/nodes.dart ('k') | pkg/compiler/lib/src/ssa/variable_allocator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698