Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/common_elements.dart ('k') | pkg/compiler/lib/src/constants/expressions.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 437a7b145c0946d6cf46fb231d707120bd4f31cf..94666231d090e22269a6dd7eb8e7849f6b55808c 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -4,7 +4,7 @@
library dart2js.compiler_base;
-import 'dart:async' show EventSink, Future;
+import 'dart:async' show Future;
import '../compiler_new.dart' as api;
import 'closure.dart' as closureMapping show ClosureTask;
@@ -39,8 +39,7 @@ import 'elements/resolution_types.dart'
ResolutionDynamicType,
ResolutionInterfaceType,
Types;
-import 'enqueue.dart'
- show DeferredAction, Enqueuer, EnqueueTask, ResolutionEnqueuer;
+import 'enqueue.dart' show Enqueuer, EnqueueTask, ResolutionEnqueuer;
import 'environment.dart';
import 'id_generator.dart';
import 'io/source_information.dart' show SourceInformation;
@@ -1786,7 +1785,7 @@ class _NoScriptLoader implements ScriptLoader {
_NoScriptLoader(this.compiler);
Future<Script> readScript(Uri uri, [Spannable spannable]) {
- compiler.reporter
+ throw compiler.reporter
.internalError(spannable, "Script loading of '$uri' is not enabled.");
}
}
« no previous file with comments | « pkg/compiler/lib/src/common_elements.dart ('k') | pkg/compiler/lib/src/constants/expressions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698