pkg/compiler/lib/src/constants/expressions.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/constants/expressions.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/constants/expressions.dart

diff --git a/pkg/compiler/lib/src/constants/expressions.dart b/pkg/compiler/lib/src/constants/expressions.dart

index 0e37c5230d0a15eb6476a47db04ae7de5b5a12d6..bdb275f23f64cf7276c8bace1aa75e298ecc5a8c 100644

--- a/pkg/compiler/lib/src/constants/expressions.dart

+++ b/pkg/compiler/lib/src/constants/expressions.dart

@@ -941,6 +941,7 @@ class BinaryConstantExpression extends ConstantExpression {

left.apply(arguments), operator, right.apply(arguments));

}

+ // ignore: MISSING_RETURN

InterfaceType getKnownType(CommonElements commonElements) {

DartType knownLeftType = left.getKnownType(commonElements);

DartType knownRightType = right.getKnownType(commonElements);

« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/dart2js.dart » ('j') | no next file with comments »