pkg/compiler/lib/src/js_backend/codegen_listener.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen_listener.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen_listener.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen_listener.dart b/pkg/compiler/lib/src/js_backend/codegen_listener.dart

index 9ddd731037594729d1890cc10f447545f4e356d8..dd5919aab2a6146fd83d253711834836298153bd 100644

--- a/pkg/compiler/lib/src/js_backend/codegen_listener.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen_listener.dart

@@ -4,12 +4,10 @@

library js_backend.backend.codegen_listener;

-import '../common.dart';

import '../common/backend_api.dart';

import '../common/names.dart' show Identifiers;

import '../common_elements.dart' show CommonElements, ElementEnvironment;

import '../constants/values.dart';

-import '../dump_info.dart' show DumpInfoTask;

import '../elements/elements.dart';

import '../elements/entities.dart';

import '../elements/resolution_types.dart';

@@ -23,11 +21,9 @@ import 'backend.dart';

import 'backend_helpers.dart';

import 'backend_impact.dart';

import 'backend_usage.dart';

-import 'constant_handler_javascript.dart';

import 'custom_elements_analysis.dart';

import 'lookup_map_analysis.dart' show LookupMapAnalysis;

import 'mirrors_analysis.dart';

-import 'mirrors_data.dart';

import 'type_variable_handler.dart';

class CodegenEnqueuerListener extends EnqueuerListener {