pkg/compiler/lib/src/resolution/members.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/members.dart

diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart

index 442464c19e95d93786cf247108cbe732f735d166..45e381d42e3c85df0775b152a48f891d841c63f8 100644

--- a/pkg/compiler/lib/src/resolution/members.dart

+++ b/pkg/compiler/lib/src/resolution/members.dart

@@ -1643,6 +1643,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {

/// Handle a [Send] whose selector is an [Operator], like `a && b`, `a is T`,

/// `a + b`, and `~a`.

+ // ignore: MISSING_RETURN

ResolutionResult handleOperatorSend(Send node) {

String operatorText = node.selector.asOperator().source;

if (operatorText == 'is') {