Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 625abbda4c0747a1e571d4e6794fc8f003ea3ec9..20c42fa2506c932e49576acfcda265e272359ee4 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -4,8 +4,6 @@
library js_backend.backend;
-import 'dart:async' show Future;
-
import 'package:js_runtime/shared/embedded_names.dart' as embeddedNames;
import '../common.dart';
@@ -986,6 +984,7 @@ class JavaScriptBackend {
return const CodegenImpact();
}
if (kind.category == ElementCategory.VARIABLE) {
+ // ignore: INVALID_ASSIGNMENT
VariableElement variableElement = element;
ConstantExpression constant = variableElement.constant;
if (constant != null) {
« no previous file with comments | « pkg/compiler/lib/src/io/position_information.dart ('k') | pkg/compiler/lib/src/js_backend/backend_helpers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698