pkg/compiler/lib/src/js_backend/backend.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/backend.dart

diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart

index 625abbda4c0747a1e571d4e6794fc8f003ea3ec9..20c42fa2506c932e49576acfcda265e272359ee4 100644

--- a/pkg/compiler/lib/src/js_backend/backend.dart

+++ b/pkg/compiler/lib/src/js_backend/backend.dart

@@ -4,8 +4,6 @@

library js_backend.backend;

-import 'dart:async' show Future;

import 'package:js_runtime/shared/embedded_names.dart' as embeddedNames;

import '../common.dart';

@@ -986,6 +984,7 @@ class JavaScriptBackend {

return const CodegenImpact();

}

if (kind.category == ElementCategory.VARIABLE) {

+ // ignore: INVALID_ASSIGNMENT

VariableElement variableElement = element;

ConstantExpression constant = variableElement.constant;

if (constant != null) {