Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: pkg/compiler/lib/src/js_backend/type_variable_handler.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import '../common.dart';
6 import '../common_elements.dart'; 5 import '../common_elements.dart';
7 import '../constants/expressions.dart'; 6 import '../constants/expressions.dart';
8 import '../constants/values.dart'; 7 import '../constants/values.dart';
9 import '../elements/resolution_types.dart'; 8 import '../elements/resolution_types.dart';
10 import '../elements/elements.dart'; 9 import '../elements/elements.dart';
11 import '../js/js.dart' as jsAst; 10 import '../js/js.dart' as jsAst;
12 import '../js_emitter/js_emitter.dart' 11 import '../js_emitter/js_emitter.dart'
13 show CodeEmitterTask, MetadataCollector, Placeholder; 12 show CodeEmitterTask, MetadataCollector, Placeholder;
14 import '../universe/call_structure.dart' show CallStructure; 13 import '../universe/call_structure.dart' show CallStructure;
15 import '../universe/use.dart' show ConstantUse; 14 import '../universe/use.dart' show ConstantUse;
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 } 170 }
172 171
173 List<jsAst.Expression> typeVariablesOf(ClassElement classElement) { 172 List<jsAst.Expression> typeVariablesOf(ClassElement classElement) {
174 List<jsAst.Expression> result = _typeVariables[classElement]; 173 List<jsAst.Expression> result = _typeVariables[classElement];
175 if (result == null) { 174 if (result == null) {
176 result = const <jsAst.Expression>[]; 175 result = const <jsAst.Expression>[];
177 } 176 }
178 return result; 177 return result;
179 } 178 }
180 } 179 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698