Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: pkg/compiler/lib/src/ssa/nodes.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import '../closure.dart'; 5 import '../closure.dart';
6 import '../common.dart'; 6 import '../common.dart';
7 import '../common/backend_api.dart' show BackendClasses; 7 import '../common/backend_api.dart' show BackendClasses;
8 import '../compiler.dart' show Compiler; 8 import '../compiler.dart' show Compiler;
9 import '../constants/constant_system.dart'; 9 import '../constants/constant_system.dart';
10 import '../constants/values.dart'; 10 import '../constants/values.dart';
(...skipping 3373 matching lines...) Expand 10 before | Expand all | Expand 10 after
3384 3384
3385 int typeCode() => HInstruction.TYPE_INFO_EXPRESSION_TYPECODE; 3385 int typeCode() => HInstruction.TYPE_INFO_EXPRESSION_TYPECODE;
3386 bool typeEquals(HInstruction other) => other is HTypeInfoExpression; 3386 bool typeEquals(HInstruction other) => other is HTypeInfoExpression;
3387 3387
3388 bool dataEquals(HTypeInfoExpression other) { 3388 bool dataEquals(HTypeInfoExpression other) {
3389 return kind == other.kind && dartType == other.dartType; 3389 return kind == other.kind && dartType == other.dartType;
3390 } 3390 }
3391 3391
3392 String toString() => 'HTypeInfoExpression($kindAsString, $dartType)'; 3392 String toString() => 'HTypeInfoExpression($kindAsString, $dartType)';
3393 3393
3394 // ignore: MISSING_RETURN
3394 String get kindAsString { 3395 String get kindAsString {
3395 switch (kind) { 3396 switch (kind) {
3396 case TypeInfoExpressionKind.COMPLETE: 3397 case TypeInfoExpressionKind.COMPLETE:
3397 return 'COMPLETE'; 3398 return 'COMPLETE';
3398 case TypeInfoExpressionKind.INSTANCE: 3399 case TypeInfoExpressionKind.INSTANCE:
3399 return 'INSTANCE'; 3400 return 'INSTANCE';
3400 } 3401 }
3401 } 3402 }
3402 } 3403 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart ('k') | pkg/compiler/lib/src/ssa/optimize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698