Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart ('k') | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart b/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
index 9d08775595542824d67d29cdccb646a687f6b24c..423ff57ff14262fa79e10dd7f3e958678c979f8a 100644
--- a/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
@@ -15,12 +15,10 @@ import '../elements/resolution_types.dart';
import '../elements/elements.dart';
import '../elements/entities.dart';
import '../elements/modelx.dart';
-import '../elements/types.dart';
import '../js/js.dart' as js;
import '../js_backend/js_backend.dart';
import '../kernel/element_adapter.dart';
import '../kernel/kernel.dart';
-import '../kernel/kernel_debug.dart';
import '../native/native.dart' as native;
import '../resolution/tree_elements.dart';
import '../tree/tree.dart' as ast;
@@ -376,9 +374,8 @@ class KernelAstAdapter extends KernelElementAdapterMixin {
KernelJumpTarget getJumpTarget(ir.TreeNode node,
{bool isContinueTarget: false}) {
return _jumpTargets.putIfAbsent(node, () {
- if (node is ir.LabeledStatement &&
- _jumpTargets.containsKey((node as ir.LabeledStatement).body)) {
- return _jumpTargets[(node as ir.LabeledStatement).body];
+ if (node is ir.LabeledStatement && _jumpTargets.containsKey(node.body)) {
+ return _jumpTargets[node.body];
}
return new KernelJumpTarget(node, this,
makeContinueLabel: isContinueTarget);
@@ -426,6 +423,7 @@ class KernelAstAdapter extends KernelElementAdapterMixin {
TypeMask get streamIteratorConstructorType =>
TypeMaskFactory.inferredReturnTypeForElement(
+ // ignore: UNNECESSARY_CAST
_backend.helpers.streamIteratorConstructor as FunctionEntity,
_globalInferenceResults);
@@ -613,11 +611,6 @@ class KernelAstAdapter extends KernelElementAdapterMixin {
getClass(cls), getDartTypes(typeArguments));
}
- @override
- InterfaceType getThisType(ir.Class cls) {
- return getClass(cls).thisType;
- }
-
MemberEntity getConstructorBodyEntity(ir.Constructor constructor) {
AstElement element = getElement(constructor);
MemberEntity constructorBody =
« no previous file with comments | « pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart ('k') | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698