Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: pkg/compiler/lib/src/js_backend/no_such_method_registry.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
diff --git a/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart b/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
index 8c86f466743977d15af879c43e449efd3082abb0..b799a9ac0e882dde5afd377ea1f61d25d6d4832c 100644
--- a/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
+++ b/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
@@ -4,7 +4,6 @@
import '../common.dart';
import '../common/names.dart' show Identifiers, Names, Selectors;
-import '../common_elements.dart';
import '../elements/elements.dart';
import '../elements/entities.dart';
import '../types/types.dart';
@@ -92,7 +91,9 @@ class NoSuchMethodRegistry {
/// that have a return type.
void onTypeInferenceComplete(GlobalTypeInferenceResults results) {
otherImpls.forEach((FunctionEntity element) {
- if (results.resultOfMember(element as MemberEntity).throwsAlways) {
+ if (results.resultOfMember(
+ // ignore: UNNECESSARY_CAST
+ element as MemberEntity).throwsAlways) {
complexNoReturnImpls.add(element);
} else {
complexReturningImpls.add(element);
« no previous file with comments | « pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart ('k') | pkg/compiler/lib/src/js_backend/type_variable_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698