Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417123002: Move GrGLShaderVar to GrGLSL (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change signature #

Patch Set 3 : fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -412 lines) Patch
M bench/GLInstancedArraysBench.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M bench/GLVec4ScalarBench.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M bench/GLVertexAttributesBench.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M gyp/gpu.gypi View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 6 chunks +25 lines, -25 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 4 chunks +10 lines, -5 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLSLBlend.cpp View 5 chunks +15 lines, -15 lines 0 comments Download
D src/gpu/gl/GrGLShaderVar.h View 1 chunk +0 lines, -256 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/gpu/glsl/GrGLSLShaderVar.h View 4 chunks +10 lines, -10 lines 0 comments Download

Dependent Patchsets:

Issue 1417993004 Patch 1

Messages

Total messages: 14 (6 generated)
egdaniel
Next step in my work to separate GLSL from GL specific code
5 years, 2 months ago (2015-10-21 14:37:12 UTC) #2
joshualitt
On 2015/10/21 14:37:12, egdaniel wrote: > Next step in my work to separate GLSL from ...
5 years, 2 months ago (2015-10-21 14:41:45 UTC) #3
robertphillips
lgtm + a question & a suggestion https://codereview.chromium.org/1417123002/diff/1/src/gpu/gl/builders/GrGLShaderBuilder.h File src/gpu/gl/builders/GrGLShaderBuilder.h (right): https://codereview.chromium.org/1417123002/diff/1/src/gpu/gl/builders/GrGLShaderBuilder.h#newcode32 src/gpu/gl/builders/GrGLShaderBuilder.h:32: should these ...
5 years, 2 months ago (2015-10-21 15:39:16 UTC) #4
egdaniel
https://codereview.chromium.org/1417123002/diff/1/src/gpu/gl/builders/GrGLShaderBuilder.h File src/gpu/gl/builders/GrGLShaderBuilder.h (right): https://codereview.chromium.org/1417123002/diff/1/src/gpu/gl/builders/GrGLShaderBuilder.h#newcode32 src/gpu/gl/builders/GrGLShaderBuilder.h:32: On 2015/10/21 15:39:16, robertphillips wrote: > should these be ...
5 years, 2 months ago (2015-10-21 17:08:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417123002/20001
5 years, 2 months ago (2015-10-21 17:08:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/3799) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 2 months ago (2015-10-21 17:10:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417123002/40001
5 years, 2 months ago (2015-10-21 17:35:31 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 17:45:51 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0d3f061262a53b775f0a92b0abf8a4a846290d65

Powered by Google App Engine
This is Rietveld 408576698