Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1417993004: Add version string and force highp NDS transfrom to GLSLCaps (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 2 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@renameShaderVar
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add version string and force highp NDS transfrom to GLSLCaps This also include the use of any() in the shaders. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cef4bce8e260b49bf3417eadbac806cf7d39cdc8 Committed: https://skia.googlesource.com/skia/+/472d44e8f881f87449d11ba66515d3c1c5e69891

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : newline nits #

Patch Set 4 : Fix glslInit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -143 lines) Patch
M bench/GLInstancedArraysBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GLVec4ScalarBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GLVertexAttributesBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 chunks +146 lines, -81 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 3 chunks +10 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
egdaniel
Another part of pulling apart gl and glsl calls https://codereview.chromium.org/1417993004/diff/20001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1417993004/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode534 src/gpu/gl/GrGLCaps.cpp:534: ...
5 years, 2 months ago (2015-10-21 21:32:44 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/1417993004/diff/20001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1417993004/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode584 src/gpu/gl/GrGLCaps.cpp:584: extra newlines?
5 years, 2 months ago (2015-10-22 13:02:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417993004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417993004/40001
5 years, 2 months ago (2015-10-22 13:44:10 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/cef4bce8e260b49bf3417eadbac806cf7d39cdc8
5 years, 2 months ago (2015-10-22 13:54:19 UTC) #8
egdaniel
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1420033002/ by egdaniel@google.com. ...
5 years, 2 months ago (2015-10-22 14:08:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417993004/60001
5 years, 2 months ago (2015-10-22 15:08:51 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 15:20:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/472d44e8f881f87449d11ba66515d3c1c5e69891

Powered by Google App Engine
This is Rietveld 408576698