Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed)

Created:
5 years, 5 months ago by hongchan
Modified:
5 years, 5 months ago
Reviewers:
brettw, jam, zel
CC:
chromium-reviews, skanuj+watch_chromium.org, sadrul, yusukes+watch_chromium.org, zea+watch_chromium.org, tzik, nektar+watch_chromium.org, dougw+watch_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, piman+watch_chromium.org, tracing+reviews_chromium.org, tfarina, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, vabr+watchlist_chromium.org, pvalenzuela+watch_chromium.org, aboxhall+watch_chromium.org, samuong+watch_chromium.org, dzhioev+watch_chromium.org, jam, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, dhollowa+watch_chromium.org, kalyank, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, samarth+watch_chromium.org, derat+watch_chromium.org, tapted, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, gunsch+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, maniscalco+watch_chromium.org, plundblad+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, wfh+watch_chromium.org, donnd+watch_chromium.org, shuchen+watch_chromium.org, asvitkine+watch_chromium.org, plaree+watch_chromium.org, David Black, jshin+watch_chromium.org, dtseng+watch_chromium.org, lcwu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kmadhusu+watch_chromium.org, peter+watch_chromium.org, estade+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move JoinString to the base namespace (patchset #9 id:160001 of https://codereview.chromium.org/1223153003/) Reason for revert: The compilation failure with the following error message: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common.chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=241602-3 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_LEGACY_SKPOINT3_CTORS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DLIBXML_STATIC -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../net/third_party/nss/ssl -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -Igen/ui/resources -Igen/extensions -Igen/extensions/strings -I../../third_party/re2 -Igen/policy -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wexit-time-destructors -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common.chrome_content_client.o ../../chrome/common/chrome_content_client.cc:193:34: error: no matching function for call to 'JoinString' std::string codec_string = base::JoinString( ^~~~~~~~~~~~~~~~ Original issue's description: > Move JoinString to the base namespace. > > Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. > > Update callers who pass empty separators to use a base::StringPiece() > > Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). > > TBR=zelidrag@chromium.org for chromeos > > Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 > Cr-Commit-Position: refs/heads/master@{#338762} TBR=jam@chromium.org,zelidrag@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b8788460cebd0e84919246968166c54f900471b2 Cr-Commit-Position: refs/heads/master@{#338770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -259 lines) Patch
M android_webview/native/aw_web_contents_delegate.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/button_from_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/crash_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_util.h View 2 chunks +16 lines, -6 lines 0 comments Download
M base/strings/string_util.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M base/strings/string_util_unittest.cc View 2 chunks +21 lines, -1 line 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_launcher_ios.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_launcher_nacl_nonsfi.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_verifier_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/content_capabilities_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/requirements_checker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/net/firefox_proxy_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/safe_search_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/suggestions/suggestions_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/certificate_error_report.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sxs_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_list_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/gcm_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/command.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/update_active_setup_version_work_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_js_browser_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/base/metrics/cast_metrics_helper.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M chromecast/base/process_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_change_notifier_chromeos.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/address.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/contact_info.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/password_form.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/top_sites_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/platform_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/policy_error_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/default_search_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/default_search_pref_migration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/keyword_table.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/search_engines/template_url.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/search_engines/template_url_service_sync_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/signin/core/browser/gaia_cookie_manager_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M components/view_manager/gesture_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/test_change_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_utils_win.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_socket_utils.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/browser/renderer_host/websocket_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/speech/google_one_shot_remote_engine.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/speech/google_streaming_remote_engine.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/websocket_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/management/management_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/vpn_provider/vpn_provider_api.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M extensions/browser/content_verifier.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/updater/manifest_fetch_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/common/csp_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/features/base_feature_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/permission_message_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/socket_permission_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/usb_device_permission.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/common/url_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/print_native_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/modules/console.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/capture_resolution_chooser.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/capabilities_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M sql/recovery.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/set_default_handler/set_default_handler_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search/history.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/search/tokenized_string_char_iterator_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_list_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_render_params_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/text_elider_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ui/message_center/views/bounded_label.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hongchan
Created Revert of Move JoinString to the base namespace
5 years, 5 months ago (2015-07-14 23:38:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237873004/1
5 years, 5 months ago (2015-07-14 23:38:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 23:41:59 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 23:43:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8788460cebd0e84919246968166c54f900471b2
Cr-Commit-Position: refs/heads/master@{#338770}

Powered by Google App Engine
This is Rietveld 408576698