components/history/core/browser/top_sites_database.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/top_sites_database.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/top_sites_database.cc

diff --git a/components/history/core/browser/top_sites_database.cc b/components/history/core/browser/top_sites_database.cc

index d1f024d315a690fe8a6c37c0bea0132009b19970..74ab1156ddaf98ca679cb082ea3e2b530e68e458 100644

--- a/components/history/core/browser/top_sites_database.cc

+++ b/components/history/core/browser/top_sites_database.cc

@@ -85,7 +85,7 @@

std::vector<std::string> redirects;

for (size_t i = 0; i < url.redirects.size(); i++)

redirects.push_back(url.redirects[i].spec());

- return base::JoinString(redirects, " ");

+ return JoinString(redirects, ' ');

}

// Decodes redirects from a string and sets them for the url.