chrome/browser/sync_file_system/drive_backend/metadata_database.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync_file_system/drive_backend/metadata_database.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database.cc

index 0859ba1c99e23e845d4264e8651053f5cfbbb8c8..f120fe3dc660398ad91807b4e4836cd897b1f70c 100644

--- a/chrome/browser/sync_file_system/drive_backend/metadata_database.cc

+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database.cc

@@ -1743,7 +1743,7 @@

std::vector<std::string> parents;

for (int i = 0; i < details.parent_folder_ids_size(); ++i)

parents.push_back(details.parent_folder_ids(i));

- dict->SetString("parents", base::JoinString(parents, ","));

+ dict->SetString("parents", JoinString(parents, ","));

}

files->Append(dict);

}