chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc

diff --git a/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc b/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc

index 638407e3bc1b8c638b76725470872631aa98fd3a..f9c8b53c89113cc51bcedcca340b967650670e0f 100644

--- a/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc

+++ b/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc

@@ -319,8 +319,7 @@

// the extensions themselves if the description is blank.

std::vector<std::string> fallback_labels_vector(fallback_labels.begin(),

fallback_labels.end());

- std::string fallback_label =

- base::JoinString(fallback_labels_vector, ",");

+ std::string fallback_label = JoinString(fallback_labels_vector, ',');

gtk_file_filter_set_name(filter, fallback_label.c_str());

}