components/search_engines/template_url_service.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_service.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url_service.cc

diff --git a/components/search_engines/template_url_service.cc b/components/search_engines/template_url_service.cc

index 12abbe8b29415f6f9269a43349659ea7623576ff..7ba2ff0ec3104f6bb050ce895de376d3e46f5383 100644

--- a/components/search_engines/template_url_service.cc

+++ b/components/search_engines/template_url_service.cc

@@ -1197,8 +1197,7 @@

se_specifics->set_safe_for_autoreplace(turl.safe_for_autoreplace());

se_specifics->set_originating_url(turl.originating_url().spec());

se_specifics->set_date_created(turl.date_created().ToInternalValue());

- se_specifics->set_input_encodings(

- base::JoinString(turl.input_encodings(), ";"));

+ se_specifics->set_input_encodings(JoinString(turl.input_encodings(), ';'));

se_specifics->set_show_in_default_list(turl.show_in_default_list());

se_specifics->set_suggestions_url(turl.suggestions_url());

se_specifics->set_prepopulate_id(turl.prepopulate_id());