chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

diff --git a/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc b/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

index 44e48204c7509874fe20e0170545c4208a96cfaa..263d03cb4383400d88b410081bee0b9d379dd798 100644

--- a/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

+++ b/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

@@ -80,7 +80,7 @@

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (succeeded)

- (*response_)[kRoutesKeyName] = base::JoinString(routes, "\n");

+ (*response_)[kRoutesKeyName] = JoinString(routes, '\n');

else

(*response_)[kRoutesKeyName] = kNotAvailable;

RequestCompleted();