components/view_manager/gesture_manager_unittest.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/gesture_manager_unittest.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/gesture_manager_unittest.cc

diff --git a/components/view_manager/gesture_manager_unittest.cc b/components/view_manager/gesture_manager_unittest.cc

index feece3137c93999060c28d2fb6487c4cd88c01e5..cc180b3c20e73e7bf2581c2b88cbe8d6b9f4791c 100644

--- a/components/view_manager/gesture_manager_unittest.cc

+++ b/components/view_manager/gesture_manager_unittest.cc

@@ -108,7 +108,7 @@

~TestGestureManagerDelegate() override {}

std::string GetAndClearDescriptions() {

- const std::string result(base::JoinString(descriptions_, "\n"));

+ const std::string result(JoinString(descriptions_, '\n'));

descriptions_.clear();

return result;

}