cloud_print/virtual_driver/win/install/setup.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/virtual_driver/win/install/setup.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/virtual_driver/win/install/setup.cc

diff --git a/cloud_print/virtual_driver/win/install/setup.cc b/cloud_print/virtual_driver/win/install/setup.cc

index fe764a108e30bee9760b25e0da07698d004eced3..07aefbca1e0ff35c9f0083c5ab4cc43b850b411e 100644

--- a/cloud_print/virtual_driver/win/install/setup.cc

+++ b/cloud_print/virtual_driver/win/install/setup.cc

@@ -283,7 +283,7 @@

driver_info.pDriverPath = const_cast<LPWSTR>(xps_path.value().c_str());

driver_info.pConfigFile = const_cast<LPWSTR>(ui_path.value().c_str());

- base::string16 dependent_files(base::JoinString(dependent_array, L"\n"));

+ base::string16 dependent_files(JoinString(dependent_array, L'\n'));

dependent_files.push_back(L'\n');

std::replace(dependent_files.begin(), dependent_files.end(), L'\n', L'\0');

driver_info.pDependentFiles = &dependent_files[0];