ash/system/user/button_from_view.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/user/button_from_view.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/user/button_from_view.cc

diff --git a/ash/system/user/button_from_view.cc b/ash/system/user/button_from_view.cc

index b3c434d47f770be421c88be7d51bcaad44781e13..c48401c91a735e2e8ec09d9185895c2bafbb86f3 100644

--- a/ash/system/user/button_from_view.cc

+++ b/ash/system/user/button_from_view.cc

@@ -89,7 +89,7 @@

std::vector<base::string16> labels;

for (int i = 0; i < child_count(); ++i)

GetAccessibleLabelFromDescendantViews(child_at(i), labels);

- state->name = base::JoinString(labels, base::ASCIIToUTF16(" "));

+ state->name = JoinString(labels, base::ASCIIToUTF16(" "));

}

void ButtonFromView::ShowActive() {

« no previous file with comments | « ash/system/chromeos/tray_display_unittest.cc ('k') | ash/system/user/user_card_view.cc » ('j') | no next file with comments »