google_apis/gaia/gaia_oauth_client.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_oauth_client.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/gaia_oauth_client.cc

diff --git a/google_apis/gaia/gaia_oauth_client.cc b/google_apis/gaia/gaia_oauth_client.cc

index c021623b5897ec85737e55bba717e768e2aebe6c..14c3cc3016df9b93b20579eea5139ce790d73d75 100644

--- a/google_apis/gaia/gaia_oauth_client.cc

+++ b/google_apis/gaia/gaia_oauth_client.cc

@@ -137,7 +137,7 @@

"&grant_type=refresh_token";

if (!scopes.empty()) {

- std::string scopes_string = base::JoinString(scopes, " ");

+ std::string scopes_string = JoinString(scopes, ' ');

post_body += "&scope=" + net::EscapeUrlEncodedData(scopes_string, true);

}