chrome/browser/ssl/ssl_blocking_page.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_blocking_page.cc

diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc

index 327fbadd3a328458d2706f79f2a09860d2867509..b47aa2e0d7f9dcef3c79059196251988a2ab61a0 100644

--- a/chrome/browser/ssl/ssl_blocking_page.cc

+++ b/chrome/browser/ssl/ssl_blocking_page.cc

@@ -455,7 +455,7 @@

ssl_info_.cert->GetPEMEncodedChain(

&encoded_chain);

load_time_data->SetString(

- "pem", base::JoinString(encoded_chain, base::StringPiece()));

+ "pem", JoinString(encoded_chain, std::string()));

cert_report_helper_->PopulateExtendedReportingOption(load_time_data);

}

« no previous file with comments | « chrome/browser/ssl/certificate_error_report.cc ('k') | chrome/browser/sxs_linux.cc » ('j') | no next file with comments »