google_apis/gaia/oauth2_mint_token_flow.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/oauth2_mint_token_flow.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/oauth2_mint_token_flow.cc

diff --git a/google_apis/gaia/oauth2_mint_token_flow.cc b/google_apis/gaia/oauth2_mint_token_flow.cc

index c2a6501b35c7de8b609e3deb920e287b2b0c01e2..0316c6328eae700f7ebf97259b8e0263355df8a0 100644

--- a/google_apis/gaia/oauth2_mint_token_flow.cc

+++ b/google_apis/gaia/oauth2_mint_token_flow.cc

@@ -167,7 +167,7 @@

net::EscapeUrlEncodedData(force_value, true).c_str(),

net::EscapeUrlEncodedData(response_type_value, true).c_str(),

net::EscapeUrlEncodedData(

- base::JoinString(parameters_.scopes, " "), true).c_str(),

+ JoinString(parameters_.scopes, ' '), true).c_str(),

net::EscapeUrlEncodedData(parameters_.client_id, true).c_str(),

net::EscapeUrlEncodedData(parameters_.extension_id, true).c_str());

if (!parameters_.device_id.empty()) {