ui/gfx/font_list_impl.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/font_list_impl.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/font_list_impl.cc

diff --git a/ui/gfx/font_list_impl.cc b/ui/gfx/font_list_impl.cc

index 907f4efa5ee1789967233d0b214b1afd91ca18a2..4037032ead84c5f2c6293ab322d5c84a6010d385 100644

--- a/ui/gfx/font_list_impl.cc

+++ b/ui/gfx/font_list_impl.cc

@@ -18,7 +18,7 @@

std::string BuildDescription(const std::vector<std::string>& families,

int style,

int size_pixels) {

- std::string description = base::JoinString(families, ",");

+ std::string description = JoinString(families, ',');

description += ",";

if (style & gfx::Font::BOLD)