chromecast/base/process_utils.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/base/process_utils.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/base/process_utils.cc

diff --git a/chromecast/base/process_utils.cc b/chromecast/base/process_utils.cc

index 9e379a05f52c67c96e027230c715c908bb220ad1..523fb1c697f0781667e17b51d450223a2833b4c5 100644

--- a/chromecast/base/process_utils.cc

+++ b/chromecast/base/process_utils.cc

@@ -17,7 +17,7 @@

DCHECK(output);

// Join the args into one string, creating the command.

- std::string command = base::JoinString(argv, " ");

+ std::string command = JoinString(argv, ' ');

// Open the process.

FILE* fp = popen(command.c_str(), "r");