components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc

index f39d95e837b7600693e40f1dcde7695c7ef6e571..9bfd9bd8fe5e00a106e84e0776fcac5cc0768c45 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc

@@ -63,7 +63,7 @@

}

config.proxy_rules().bypass_rules.ParseFromString(

- base::JoinString(bypass_rules_, ", "));

+ JoinString(bypass_rules_, ", "));

// The ID is set to a bogus value. It cannot be left uninitialized, else the

// config will return invalid.

net::ProxyConfig::ID unused_id = 1;