chrome/browser/extensions/crx_installer.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 2effb1afb6afdec33265efc406e46631acc31ed5..714906ca2c295f5e641e1254e4f3cd46a747a3ae 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -536,8 +536,8 @@

if (error_on_unsupported_requirements_) {

ReportFailureFromUIThread(

CrxInstallError(CrxInstallError::ERROR_DECLINED,

- base::UTF8ToUTF16(base::JoinString(

- install_checker_.requirement_errors(), " "))));

+ base::UTF8ToUTF16(JoinString(

+ install_checker_.requirement_errors(), ' '))));

return;

}

install_flags_ |= kInstallFlagHasRequirementErrors;