chrome/browser/extensions/webstore_installer.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 6ab5475321b80b78b06a110033e03dd770168ce5..cbfd025a7ddc38769ffa6be1e5aab260746df582 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -217,8 +217,7 @@

GURL url(url_string + "?response=redirect&" +

update_client::UpdateQueryParams::Get(

update_client::UpdateQueryParams::CRX) +

- "&x=" + net::EscapeQueryParamValue(base::JoinString(params, "&"),

- true));

+ "&x=" + net::EscapeQueryParamValue(JoinString(params, '&'), true));

DCHECK(url.is_valid());

return url;