chrome/test/base/extension_js_browser_test.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/extension_js_browser_test.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/extension_js_browser_test.cc

diff --git a/chrome/test/base/extension_js_browser_test.cc b/chrome/test/base/extension_js_browser_test.cc

index f6396d0d6d8bd4e966350ac25b82a078f2ac82dd..b84d2231ecfbb203ef8823b403038995e25883ac 100644

--- a/chrome/test/base/extension_js_browser_test.cc

+++ b/chrome/test/base/extension_js_browser_test.cc

@@ -42,8 +42,7 @@

}

scripts.push_back(BuildRunTestJSCall(is_async, "RUN_TEST_F", args));

- base::string16 script_16 =

- base::JoinString(scripts, base::ASCIIToUTF16("\n"));

+ base::string16 script_16 = JoinString(scripts, '\n');

std::string script = base::UTF16ToUTF8(script_16);

std::string result =