chrome/browser/thumbnails/thumbnail_list_source.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnail_list_source.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/thumbnails/thumbnail_list_source.cc

diff --git a/chrome/browser/thumbnails/thumbnail_list_source.cc b/chrome/browser/thumbnails/thumbnail_list_source.cc

index 0cad21f9d5b333b9884e3c6eb186603a064c3fbd..604b3d368a5582150c49af86c34ccd9412fe8e09 100644

--- a/chrome/browser/thumbnails/thumbnail_list_source.cc

+++ b/chrome/browser/thumbnails/thumbnail_list_source.cc

@@ -164,6 +164,6 @@

}

out.push_back(kHtmlFooter);

- std::string out_html = base::JoinString(out, base::StringPiece());

+ std::string out_html = JoinString(out, "");

callback.Run(base::RefCountedString::TakeString(&out_html));

}